0.23.40: backport ECH padding fixes to 0.23 - #3044
Merged
Merged
Conversation
In the case where SNI is disabled, `inner_sni` falls out of sync with `self.inner_name`. `inner_sni` is used to alter the inner hello's `server_name`, but `self.inner_name` was used as a basis for padding. This means padding would be added even if the extension wasn't, which ironically leaks the length of the inner name.
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Memory usageKey:
Significant differencesThere are no significant memory usage differences Additional informationCheckout details:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel-0.23 #3044 +/- ##
============================================
+ Coverage 95.29% 95.31% +0.02%
============================================
Files 97 97
Lines 21852 21938 +86
============================================
+ Hits 20823 20910 +87
+ Misses 1029 1028 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cpu
approved these changes
Apr 28, 2026
cpu
left a comment
Member
There was a problem hiding this comment.
Prepare 0.23.40
Can you also propose some release notes for review? 🙇
djc
approved these changes
Apr 28, 2026
Member
Author
Added, PTAL |
Member
Would it be more accurate to describe this as fixing the RFC-recommended padding? I think we did at least attempt to implement it initially right? Otherwise LGTM. |
Member
|
LGTM. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed release notes:
ServerConfig::require_emsbased on provider's FIPS status. Prior to this change, the default followed thefipscrate feature, which was less helpful for users of external FIPS-approved providers.