unused_trait_names: make the suggestion nicer - #17589
Merged
Merged
Conversation
- make the message more descriptive - reduce the diff - make the suggestion verbose, so that the diff can be color-coded (and because it'd get formatted awkwardly otherwise)
Collaborator
|
Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews. In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews. |
CommanderStorm
approved these changes
Aug 19, 2026
|
Lintcheck changes for feda972
This comment will be updated if you push new changes |
Contributor
Author
|
I mean you're not wrong.. I'm just a sucker for smaller diffs^^ |
Contributor
I meant "not really a substantial difference from my point of view", not git diff 😉 |
Contributor
Author
|
And I meant "diff" as in "suggestion diff" 😅 Meaning this: instead of this: |
dswij
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: none
(because the change is not that significant imo)