fix(useless_conversion): ignore From::from in generated code - #17583
Conversation
|
Thanks for the pull request, and welcome! You should hear from one of our reviewers after this PR gets at least 2 reviews from the community. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
12684da to
1e9b5e4
Compare
|
like this @CommanderStorm ? |
|
yes, tnx |
|
Hello @NicDevTV, seems that an LLM assisted in this PR, we require disclosure as per the LLM policy |
|
@blyxyas Yes, I used an LLM while working on this PR. I used it to help me understand parts of the codebase and to explore a possible solution approach. I reviewed and understood the approach myself and implemented the actual changes on my own. |
|
In that case, please follow our LLM policy and reword your PR description accordingly |
1e9b5e4 to
4f9cf04
Compare
|
r? @Manishearth rustbot has assigned @Manishearth for the project review. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Fixes
useless_conversionbeing triggered forFrom::from(...)in#[automatically_derived]code.The lint now skips those cases and the UI test has been updated accordingly.
I used an LLM to help understand parts of the codebase and explore the approach. The final change was reviewed, understood and implemented by me.
changelog: [
useless_conversion]: Don't lintFrom::fromin automatically derived codeFixes #17083