Conversation
xmakro
marked this pull request as ready for review
July 12, 2026 03:30
Contributor
|
#17308 also does this. |
CommanderStorm
suggested changes
Jul 26, 2026
Contributor
There was a problem hiding this comment.
Community review:
I like #17308 a lot more than this solution.
Modeling "the full state space" using enums is much nicer longer-term 👍🏻
Collaborator
|
☔ The latest upstream changes (possibly #17308) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
|
Closing since #17308 was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared context guard for
used_underscore_bindingandused_underscore_items(external-macro, desugaring, and automatically-derived checks) is expensive and ran on every expression, though the lints can only fire on names starting with a single underscore.changelog: none