Clean-up used_underscore_* - #17308
Merged
Merged
Conversation
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Lintcheck changes for dc22b72
This comment will be updated if you push new changes |
Contributor
|
Can you add some tests to show the modified behavior re consts/statics etc.? |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Ok, I'm convinced. Sorry for the delay. r=me after rebase. |
* Merge the code for both lints * Don't lint in macros * Allow `expect` and `allow` on the item's definition * Better match `unused_variables` * Re-order checks based on cost/effectivness.
Jarcho
force-pushed
the
used_underscore
branch
from
August 12, 2026 15:49
8082081 to
3013083
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
Ended up just rewriting both tests. They should be easier to follow as a whole. |
tamird
added a commit
to aya-rs/aya
that referenced
this pull request
Aug 25, 2026
Clippy now checks constants and type-relative paths for used_underscore_items [1]. This first ships in nightly-2026-08-25, where the BTF maps' references to Self::_CHECK fail CI. Rename these private constants to CHECK, including the shared hash-map macro, and update their references. Keep each let () = Self::CHECK so the kernel constraints and alignment assertions are still evaluated when the corresponding map methods are instantiated. Refs: #1691 [1]: rust-lang/rust-clippy#17308
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This primarily reorders things to do cheaper checks before more expensive checks, but there are also some smaller changes:
expectandallowon the item inused_underscore_itemsnow work.used_undercore_bindingsalready did this.is_usednow more closely matches whatunused_variablesdoes. It takes very little for a variable to count as used.consts/staticsand all type relative paths are checkedchangelog: [
used_underscore_bindings]: lint more cases where the binding is usedchangelog: [
used_underscore_items]: additionally check forallowendexpectattributes on the item definition.