fix: Panic on accessing numeric fields in unions - #23229
Merged
ChayimFriedman2 merged 1 commit intoAug 25, 2026
Merged
Conversation
When writing `foo.0` where `foo` is a union, we'd end up panicking with:
Failed to make ast node `syntax::ast::generated::nodes::Name` from text mod 0;
This is because `make::name()` requires a legal ident. In
480db31 we added checks for numeric
fields (i.e. `.0` instead of `.foo`) in several code paths but missed
the union case.
Rather than adding another check, just change the fix to never be
offered when the field name isn't a valid identifier.
Add a unit test for the union case too.
AI disclosure: Code partly written by GPT-5.6, review and commit
message by me.
ChayimFriedman2
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing
foo.0wherefoois a union, we'd end up panicking with:This is because
make::name()requires a legal ident. In 480db31 we added checks for numeric fields (i.e..0instead of.foo) in several code paths but missed the union case.Rather than adding another check, just change the fix to never be offered when the field name isn't a valid identifier.
Add a unit test for the union case too.
AI disclosure: Code partly written by GPT-5.6, review and commit message by me.