perf(fmt): optimize root gitignore matching - #166
Merged
Conversation
Deploying rstack-cli with
|
| Latest commit: |
95ccf7e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c773727a.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-gitignore-root-ma.rstack-cli.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Most projects only have a root
.gitignore, but formatting discovery still walked every path segment and performed matcher map lookups for each candidate. This PR directly uses the root matcher when it is the only loaded matcher, while retaining layered matching as soon as a nested.gitignoreis present.Benchmark
discoverFmtPaths("packages")with 10,001 candidate files (representative path depth: 7), only a root.gitignore, Node.js v24.12.0 on macOS arm64. Median of 20 runs after 5 warmups:This reduces discovery time by 34.5%, a 1.53× speedup.