perf(fmt): reduce Yuku plugin bundle size - #165
Open
chenjiahan wants to merge 3 commits into
Open
Conversation
Deploying rstack-cli with
|
| Latest commit: |
01aba4a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d072c83c.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-feat-lightweight.rstack-cli.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff41c38bcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@prettier/plugin-yukubundles a full copy of Prettier's JavaScript printer into the formatter worker. This replaces it with a local Yuku parser/postprocess adapter that reusesprettier/plugins/estreeand mirrors the required Prettier location and pragma behavior locally, without eagerly loadingprettier/plugins/babel.The adapter preserves current official behavior: 230/230 successful official fixture ASTs match exactly, 502 format comparisons have no output or status differences, and the local pragma/location helpers match Prettier's implementations across 5,015 pragma samples and 22 location cases.
Bundle Size
dist/fmtWorker.jsThis also removes the
@prettier/plugin-yukudependency and its duplicated bundled code.Runtime Performance
Compared PR head
01aba4awith main68c6f25on the same 145 tracked JavaScript/TypeScript files using Node.js 24.12.0. Results are medians from alternating runs: 40 cold-start samples and 15 samples per warm/CLI variant. The default CLI uses 8 workers.The package-size reduction therefore does not introduce a measurable runtime regression. Removing the eager Babel plugin load also eliminates the earlier parallel-worker startup and memory overhead.
Related Links