Add file name compression - #4496
Merged
Merged
Conversation
Allows to compress short arbitrary strings and returns a string using base64 url encoding. Generator for tables included and a few samples has been added. Add more to init.go Tested with fuzzing for crash resistance and symmetry, see fuzz.go Requires klauspost/compress#275 - until release a replace has been added to go.mod
klauspost
force-pushed
the
add-filename-compression
branch
from
August 10, 2020 20:27
4005cbf to
570e052
Compare
Contributor
Author
|
Fuzz corpus: testdata.zip - didn't want to add 370 files to repo. |
Contributor
Author
|
The change is merged to master. Will be released as v1.10.11 eventually - replacing it with master for now. When you have added tables adding regression tests for a bunch of strings should be trivial. |
ncw
approved these changes
Aug 13, 2020
ncw
left a comment
Member
There was a problem hiding this comment.
That is brilliant, thank you Klaus :-)
I'll merge that now.
I'll probably need to change the interface a bit when I glue it onto crypt, but that can wait for the moment.
PS The test failure was a heisenbug - I've nearly killed them all but there are a few left!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Allows to compress short arbitrary strings and returns a string using base64 url encoding.
Generator for tables included and a few samples has been added. Add more tables to init.go
Tested with fuzzing for crash resistance and symmetry, see fuzz.go - new tables should not affect this.
Requires klauspost/compress#275 - until release a replace has been added to go.mod
Was the change discussed in an issue or in the forum before?
Yes. Twitter.
Checklist
go.mod.