gh-157672: Keep Python's signal handlers when Tk is initialized on macOS - #157673
Open
serhiy-storchaka wants to merge 1 commit into
Open
serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
… on macOS Tk on macOS replaces the SIGINT, SIGHUP and SIGTERM handlers with its own, which exits the process, so Ctrl-C terminated a tkinter program instead of raising KeyboardInterrupt. Save the handlers installed by Python before Tk_Init() and restore them after it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tk on macOS replaces the SIGINT, SIGHUP and SIGTERM handlers with its own, which exits the process with status 1, so Ctrl-C terminated a tkinter program instead of raising
KeyboardInterrupt, and Python-level handlers of SIGTERM and SIGHUP stopped working. Save the handlers installed by Python beforeTk_Init()and restore them after it. Handlers which areSIG_DFLare not restored, which matches the fix on the Tk side (branch mac-signal-handlers): Tk's handler is only kept for signals which Python does not handle.The test runs in a subprocess, because the process exits without the fix.
🤖 Generated with Claude Code