gh-74112: Make Ctrl-C in the IDLE Shell interrupt blocking calls - #157662
Open
serhiy-storchaka wants to merge 1 commit into
Open
serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Send a real SIGINT to the main thread of the user process instead of calling _thread.interrupt_main(), which only sets a flag checked between bytecodes. The signal is sent while holding a new lock which protects sending a message, so that the main thread is not interrupted in the middle of a message. An interrupted wait for a response now releases its lock, so that the socket thread does not deadlock.
Member
Author
|
@terryjreedy, to test manually: start IDLE, then in the Shell enter each of the following, wait a second, and press Ctrl-C. Each should print a
|
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_thread.interrupt_main()only sets a flag which is checked between bytecodes, so Ctrl-C did not interrupttime.sleep(),socket.recv()and other blocking calls. Now a real SIGINT is sent to the main thread of the user process: withsignal.pthread_kill(), or withsignal.raise_signal()on Windows, where the C signal handler wakes up the main thread._thread.interrupt_main()is still used when SIGINT is not handled by Python.Sending a message is now protected by a lock, and the signal is sent while holding it. Otherwise the main thread could be interrupted in the middle of a message, and the GUI process would wait for its end forever; this happened regularly on Windows during large output. An interrupted wait for a response now releases its lock, so that the socket thread does not deadlock (the problem observed in #2466).
Tested on Linux and Windows with
time.sleep(),input(), loops with large output, andsocket.recv()(not interruptible on Windows, as in a console).🤖 Generated with Claude Code