gh-139314: Add support for linking against zlib-rs and libbzip2-rs - #155119
Open
StanFromIreland wants to merge 1 commit into
Open
gh-139314: Add support for linking against zlib-rs and libbzip2-rs#155119StanFromIreland wants to merge 1 commit into
zlib-rs and libbzip2-rs#155119StanFromIreland wants to merge 1 commit into
Conversation
StanFromIreland
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
August 3, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finished off what was started in #139315. I also opted to implement the more generic configure options (based on the ones we have for other libraries, like
--with-cursesand--with-readline) as discussed in the issue.The tests pass when built with
zlib-rs(as expected), but also result in a spurious debug message fromzlib-rsending up in stderr. I've reported this upstream in trifectatechfoundation/zlib-rs#553.