-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
gh-153480: Stop IDLE crashing when a file open in the editor is deleted #153481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tonghuaroot
wants to merge
5
commits into
python:main
Choose a base branch
from
tonghuaroot:idlelib-editor-last-mtime-oserror
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+115
−3
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5a78710
gh-153480: Stop IDLE crashing when a file open in the editor is deleted
tonghuaroot 2f20bc2
Merge branch 'main' into idlelib-editor-last-mtime-oserror
serhiy-storchaka a57c59b
gh-153480: Return None from last_mtime() and handle a deleted file
tonghuaroot e84056b
Fix end-of-file newline in editor.py and test_editor.py
tonghuaroot ceffab2
gh-153480: Clear mtime in the deleted-file dialog before Save As
tonghuaroot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
Misc/NEWS.d/next/IDLE/2026-07-10-19-41-00.gh-issue-153480.EdMt1x.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Fix IDLE failing to start when opening a file which does not exist yet. | ||
| Fix a traceback when a file open in the IDLE editor is deleted by another | ||
| program; IDLE now asks whether to close the window, save the file elsewhere, | ||
| or ignore it. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a modified buffer, Close asks whether to save, and the FocusIn event queued when this dialog closed is delivered inside that message box, so the dialog is shown a second time (and currently crashes on the message box's grab, a separate tkinter bug). Set
self.mtime = Nonebefore showing the dialog, for all choices; a successful Save As sets it again.