Conversation
Code coverage summaryNote:
pubnativeRefer here for heat map coverage report smaatoRefer here for heat map coverage report |
linux019
requested changes
Aug 17, 2026
Enigo
force-pushed
the
ADS-4458_prebid_b___convert_eur_bid_floors_to_usd_
branch
from
August 18, 2026 15:05
d2c79d5 to
4c8c629
Compare
Code coverage summaryNote:
pubnativeRefer here for heat map coverage report smaatoRefer here for heat map coverage report |
Code coverage summaryNote:
pubnativeRefer here for heat map coverage report smaatoRefer here for heat map coverage report |
linux019
approved these changes
Aug 20, 2026
|
Hi, |
|
@linux019 Can you please help me understand how we can tap into another reviewer for this PR? |
Contributor
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54480228a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
przemkaczmarek
approved these changes
Sep 9, 2026
Contributor
Author
|
@przemkaczmarek @linux019 |
Collaborator
|
@Enigo its not Your fault, We have prepared fix for it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding currency conversion for both Smaato and Pubnative adapters.
Both only support USD