Conversation
rubencm
marked this pull request as draft
September 12, 2026 18:59
|
The attempt to merge branch
A separate PR will be needed to merge |
rubencm
force-pushed
the
ticket/17699
branch
from
September 15, 2026 20:23
5284d7a to
ad8a322
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Common punctuation in valid ASCII subjects remains unnecessarily encoded, leaving the reported spam-filter risk unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Prevents spam-filter rejection by reducing unnecessary email header encoding and avoiding sender-matching Reply-To addresses.
Changes:
- Leaves eligible ASCII headers unencoded.
- Avoids setting sender Reply-To when sender is the recipient.
- Adds coverage for header encoding and Reply-To behavior.
File summaries
| File | Description |
|---|---|
phpBB/includes/functions_messenger.php |
Adjusts ASCII header encoding. |
phpBB/phpbb/message/message.php |
Conditionally sets Reply-To. |
tests/email/headers_encoding_test.php |
Tests header encoding behavior. |
tests/message/message_test.php |
Tests sender/recipient Reply-To handling. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rubencm
marked this pull request as ready for review
September 17, 2026 09:14
CHItA
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPBB-17699
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17699