-
Notifications
You must be signed in to change notification settings - Fork 418
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: pdfkit/pdfkit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.8.5
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: pdfkit/pdfkit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.8.7.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 12 files changed
- 5 contributors
Commits on Apr 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 46cdf53 - Browse repository at this point
Copy the full SHA 46cdf53View commit details
Commits on Sep 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 41068fd - Browse repository at this point
Copy the full SHA 41068fdView commit details
Commits on Oct 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 54b4941 - Browse repository at this point
Copy the full SHA 54b4941View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d0a162 - Browse repository at this point
Copy the full SHA 6d0a162View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6213317 - Browse repository at this point
Copy the full SHA 6213317View commit details
Commits on Oct 12, 2022
-
fix: support non-lower-case Content-Type header provided by app (#516)
* fix: support non-lower-case Content-Type header provided by app The changes in #511 change what headers get set by PDFKit and make all headers set by PDFKit lower-case. However, the changes also affect code depending on headers set by the app - which for Rack 2.x apps will be 'Content-Type'. To address this, the code should check if Content-Type is present and in that case use it, otherwise default to content-type. As the code also sets this header (changing the content type to 'application/pdf'), it should set the same header that the original value is retrieved from. So decide on the exact header name first, store it in the 'content_type_header' variable, and use it to index the headers dict. Fix #515. * rspec: add tests for mixed case Content-Type header support As rack 3.x outright rejects mixed case headers, this test has to be marked as pending - but passes (without the pending flag) with rack 2.x. * rspec/content-type: make mixed case test pending only on Rack>=3.0.0
Configuration menu - View commit details
-
Copy full SHA for 089e5de - Browse repository at this point
Copy the full SHA 089e5deView commit details
Commits on Oct 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ceca488 - Browse repository at this point
Copy the full SHA ceca488View commit details
Commits on Oct 18, 2022
-
Call
IO.popenwith an Array of command arguments (#518). (#519)* By calling `IO.popen` with an Array of command arguments (ex: `['ls', '-l', ...]`) it runs the command as a separate process instead of running it in a sub-shell as a shell command. This prevents any arbitrary command injection or env variable interpolation, without needing complex shell-escaping logic. https://ruby-doc.org/core-3.1.2/IO.html#method-c-popen * Changed `Configuration#executable` to return a String or an Array for when xvfb mode is enabled. * Changed `PDFKit#command` to return an Array of command arguments for `IO.popen`. * Removed argument quoting logic as it's not necessary when calling `IO.popen` with an Array of arguments. * Rewrote some specs to test if the command's Array of arguments contains specific argument values. * Added a custom RSpec `contain` matcher for testing if an expected Array exists within another Array.
Configuration menu - View commit details
-
Copy full SHA for 79ec0c0 - Browse repository at this point
Copy the full SHA 79ec0c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 404a5a4 - Browse repository at this point
Copy the full SHA 404a5a4View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.8.5...v0.8.7.2