Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pdfkit/pdfkit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.8.5
Choose a base ref
...
head repository: pdfkit/pdfkit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.8.7.2
Choose a head ref
  • 9 commits
  • 12 files changed
  • 5 contributors

Commits on Apr 11, 2022

  1. Bump to 0.8.6 (#504)

    serene authored Apr 11, 2022
    Configuration menu
    Copy the full SHA
    46cdf53 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Configuration menu
    Copy the full SHA
    41068fd View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. Configuration menu
    Copy the full SHA
    54b4941 View commit details
    Browse the repository at this point in the history
  2. Fix typo (#510)

    mdh authored Oct 2, 2022
    Configuration menu
    Copy the full SHA
    6d0a162 View commit details
    Browse the repository at this point in the history
  3. Bump to 0.8.7 (#513)

    serene authored Oct 2, 2022
    Configuration menu
    Copy the full SHA
    6213317 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. fix: support non-lower-case Content-Type header provided by app (#516)

    * fix: support non-lower-case Content-Type header provided by app
    
    The changes in #511 change what headers get set by PDFKit
    and make all headers set by PDFKit lower-case.
    
    However, the changes also affect code depending on headers
    set by the app - which for Rack 2.x apps will be 'Content-Type'.
    
    To address this, the code should check if Content-Type is present
    and in that case use it, otherwise default to content-type.
    
    As the code also sets this header (changing the content type
    to 'application/pdf'), it should set the same header that
    the original value is retrieved from.
    
    So decide on the exact header name first, store it in the
    'content_type_header' variable, and use it to index the
    headers dict.
    
    Fix #515.
    
    * rspec: add tests for mixed case Content-Type header support
    
    As rack 3.x outright rejects mixed case headers, this test has to be marked
    as pending - but passes (without the pending flag) with rack 2.x.
    
    * rspec/content-type: make mixed case test pending only on Rack>=3.0.0
    vladimir-mencl-eresearch authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    089e5de View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Bump to 0.8.7.1 (#520)

    serene authored Oct 17, 2022
    Configuration menu
    Copy the full SHA
    ceca488 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Call IO.popen with an Array of command arguments (#518). (#519)

    * By calling `IO.popen` with an Array of command arguments
      (ex: `['ls', '-l', ...]`) it runs the command as a separate process
      instead of running it in a sub-shell as a shell command. This prevents
      any arbitrary command injection or env variable interpolation, without
      needing complex shell-escaping logic.
      https://ruby-doc.org/core-3.1.2/IO.html#method-c-popen
    * Changed `Configuration#executable` to return a String or an Array for
      when xvfb mode is enabled.
    * Changed `PDFKit#command` to return an Array of command arguments for
      `IO.popen`.
    * Removed argument quoting logic as it's not necessary when calling
      `IO.popen` with an Array of arguments.
    * Rewrote some specs to test if the command's Array of arguments contains
      specific argument values.
    * Added a custom RSpec `contain` matcher for testing if an expected Array
      exists within another Array.
    postmodern authored Oct 18, 2022
    Configuration menu
    Copy the full SHA
    79ec0c0 View commit details
    Browse the repository at this point in the history
  2. Bump to 0.8.7.2 (#521)

    serene authored Oct 18, 2022
    Configuration menu
    Copy the full SHA
    404a5a4 View commit details
    Browse the repository at this point in the history
Loading