Conversation
The CMake build links libatomic on every architecture, but the library imports no symbol from it. Link with --as-needed so the unused library is dropped and remove the dependency. Signed-off-by: Daniel Golle <[email protected]>
libatomic is only needed where the compiler does not inline 64-bit atomics, but the package depends on it on every target. ATOMIC64_DEPENDS restricts the dependency to those targets. Signed-off-by: Daniel Golle <[email protected]>
The CMake build links libatomic on every architecture, but the library imports no symbol from it. Link with --as-needed so the unused library is dropped and remove the dependency. Signed-off-by: Daniel Golle <[email protected]>
|
CI note: the failing build jobs on the 32-bit targets (mips, mipsel, powerpc, ARMv5) are expected until the snapshot SDKs include openwrt/openwrt@e23f575. The current SDKs (r36237 and older) predate that commit, so |
|
Correction for this feed: the 32-bit jobs here passed even with the pre-merge SDKs because the packaging check accepts libraries provided by any transitive dependency and libsrtp2 pulls in libopenssl, which already depends on libatomic on those targets. The actual failures are unrelated to the change: mips_24kc, arm_cortex-a15_neon-vfpv4 and x86_64 died with |
Maintainer: rtpproxy Jiri Slachta, libks and signalwire-client-c have no maintainer listed
Compile tested: ramips/mt7621 and x86/64 snapshot SDKs (r36222) with openwrt/openwrt#25112 applied; every package passes the packaging dependency check on both
Run tested: none, build and packaging tests only
Description:
Follow-up to openwrt/openwrt#25112, which added
HAS_ATOMIC64andATOMIC64_DEPENDS:=+!HAS_ATOMIC64:libatomic: the compiler calls libatomic for 64-bit atomics only on mips, mipsel, powerpc and ARM below ARMv6K. This reworks the three packages in this feed that depend on libatomic according to what their built binaries import (readelf -DWson the packaged files):__atomic_fetch_add_8,__atomic_load_8and__atomic_store_8on mips:+libatomicbecomes$(ATOMIC64_DEPENDS).--as-needed, so noNEEDED libatomic.so.1remains.