release: v0.34.0 (Firefox 150) + release tooling fixes - #1166
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Release bump to OpenWPM v0.34.0 targeting Firefox 150, plus fixes to the release/update tooling to ensure future automated bumps (Firefox + linters + npm deps) work reliably.
Changes:
- Bump release version metadata and add a v0.34.0 changelog entry.
- Pin the Firefox unbranded build to
FIREFOX_150_0_2_RELEASEand harden Firefox tag auto-detection (Accept: application/json). - Update Node/Extension dependency tooling: TS config updates, TypeScript pinning behavior in
scripts/update.py, and dependency refreshes (npm + conda + pre-commit).
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
VERSION |
Updates project version to 0.34.0. |
CHANGELOG.md |
Adds v0.34.0 release notes and tooling notes. |
scripts/install-firefox.sh |
Pins Firefox download tag to FIREFOX_150_0_2_RELEASE. |
scripts/firefox_version.py |
Adds Accept: application/json header for Firefox tag fetch. |
scripts/update.py |
Keeps npm-check-updates from upgrading TypeScript (stay on 5.x). |
package.json |
Bumps root dev tooling deps (commitlint). |
package-lock.json |
Updates lockfile to reflect root dependency upgrades. |
Extension/tsconfig.json |
Moves TS module settings to Node16-compatible values. |
Extension/tsconfig.module.json |
Aligns module build config with Node16 module semantics. |
Extension/package.json |
Updates Extension devDependencies including pinning TypeScript to ^5.9.3. |
Extension/package-lock.json |
Updates Extension lockfile for refreshed toolchain versions. |
environment.yaml |
Repins conda environment versions (including linters used by pre-commit sync). |
.pre-commit-config.yaml |
Syncs mypy hook rev to match the pinned conda version. |
Files not reviewed (1)
- Extension/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1166 +/- ##
=======================================
Coverage 62.17% 62.17%
=======================================
Files 40 40
Lines 3902 3902
=======================================
Hits 2426 2426
Misses 1476 1476 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vringar
force-pushed
the
release/v0.34.0
branch
2 times, most recently
from
May 7, 2026 20:23
9c666ef to
7659ba1
Compare
- Bump VERSION 0.32.0 → 0.34.0 and add CHANGELOG entry for v0.34.0 - scripts/install-firefox.sh: bump to FIREFOX_150_0_2_RELEASE - scripts/firefox_version.py: send Accept: application/json header. The hg.mozilla.org → hg-edge.mozilla.org migration broke the JSON endpoint under default Accept (HTML page returned), silently disabling Firefox auto-detect. - Extension/tsconfig*.json: switch moduleResolution from "node" (deprecated in TS 6, gone in TS 7) to "node16". module set to "node16" for compatibility. - scripts/update.py: pin TypeScript to 5.x via --reject typescript. TS 6 enables stricter inference defaults that surface ~200 latent type issues in Extension/src; the migration is its own PR. - environment.yaml + lockfiles: refreshed by repin
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
May 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release for Firefox 150, plus the tooling fixes that were required to unblock the release.
v0.34.0 — Firefox 150
VERSION0.32.0 → 0.34.0 (the previous release tagged v0.33.0 without bumping VERSION; this catches up).scripts/install-firefox.sh: pin toFIREFOX_150_0_2_RELEASE.failure_countrace fix, linter sync).Release tooling fixes (smashed into this PR per request)
scripts/firefox_version.py— silent Firefox auto-detect failure. The endpoint moved fromhg.mozilla.orgtohg-edge.mozilla.org, which content-negotiates and returns the HTML web UI when noAcceptheader is sent.urllib.request.urlopen(url)was getting HTML and throwingJSONDecodeError, whichupdate.pyswallowed. Every release since the migration would have skipped the Firefox bump. Fix: sendAccept: application/json.Extension/tsconfig*.json— fixmoduleResolution: "node"deprecation properly. TS 6 deprecates thenodealias; TS 7 will remove it. Switched bothtsconfig.jsonandtsconfig.module.jsontonode16(non-deprecated, compatible withmodule: commonjs/module: node16). Not silenced viaignoreDeprecations.scripts/update.py— pin TypeScript to 5.x. TS 6's stricter inference defaults (TS7006 implicit-any on parameters/members, TS2564 strictPropertyInitialization, TS18048 possibly-undefined, TS18046 unknown-in-catch) surface ~200 latent type issues across 19 files inExtension/src. Fixing those is its own migration PR; until then,npm-check-updates --reject typescriptkeeps the bumper inside 5.x.Test plan
python scripts/update.pyruns to completion and bumpsinstall-firefox.shto FF 150_0_2./scripts/install-firefox.shsucceedscd Extension && npm run buildis clean (no errors, no deprecation warnings)pre-commit run --all-filespassespytest -m pyonlypasses (9/9)Follow-ups (not in this PR)
firefox_version.py,tsconfig,update.py) ideally would be a separate prep PR landed before this one — bundled here per your request to keep this as one "fix everything" PR.