Fix Pages browser dependency isolation - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The approved Pages deployment failed twice because Playwright's dependency installation refreshed an unrelated Google Chrome APT repository whose package index had a checksum mismatch.
Install the pinned Playwright system dependencies using a process-local APT configuration that selects the runner's existing Ubuntu 24.04 source definition, an empty additional-source directory and temporary indexes. Preserve the existing Ubuntu mirrors and signed keyring, all authentication/TLS/hash checks, the pinned Playwright/browser versions and the unchanged full
pnpm verify:agentctlgate. No system repository files are edited. Browser download remains a separate unprivileged pinned CLI invocation.Validation:
1fe9a953062d212d2c6ad029106a6ec7b77471b75191f88c40b0bcca04ef1b43; independent inspection verified all 94 HTML pages, source metadata and all 21 packages. Earlier failed deployment attempts 34384620405/1 and 2 remain recorded in the execution ledger.The framework pin remains
7dee64e1d1b6fd38c1883d0d235d712590c30fbe; imported docs and all 21 downloadable packages are unchanged. This PR fixes the deployment prerequisite only.Additional historical archive comparison found one generated CSS difference: the current build retains the existing authored homepage card background/padding rule that the older 2f2 artifact omitted; remaining HTML differences are only the corresponding stylesheet filename. Maintained source and lockfile are identical, and source metadata/all 21 packages remain byte-identical. The failed strict historical comparison and complete difference characterization are retained separately. Public deployment verification will use this exact newly validated artifact.
Deployment completed at merge
f53941091e366b27c097cfd14bab2d043c9d130b: Pages run 34390286498 passed full validation (140 browser checks, one unchanged skip) and deployed successfully. Independent public verification confirmed 92 HTML pages, all 21 downloads, metadata and six CSS files match the actual Pages artifact. All 346 nonhidden deployed-artifact files match this reviewed PR build. Source metadata remains exact 7dee64e; all nested manifests/payload hashes pass; visible source boilerplate is absent. Chrome search and the 390px tutorial passed, with the stale role-limit sentence absent. Actual Pages ZIP SHA256:7ce96b7dd581c69ac496dce179b4aa5063bbc62dc7925659cb82048aa7f2e308. The pinned official Pages uploader omits.nojekyll; the reviewed validation artifact contains it.