Skip to content

Rename arguments of list_evaluations to indicate they expect lists of ids #804

Description

@PGijsbers

See also #796. It was a step forward, but the argument names still don't convey that we are looking for a list (i.e. argument name should be plural) or ids as opposed to OpenML objects (e.g. by a suffix _id).

I would argue that we also should update the type hints (to Optional[List[Union[str, int]]]) and add parameter descriptions in the docstring.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

DocumentationGood First IssueIssues suitable for people new to contributing to openml-python!

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions