Update eventmachine gem from 1.0.4 to 1.2 - #251
Merged
Merged
Conversation
|
Will this get merged into |
Collaborator
|
Released in 1.1.3 @mwjeffcott / @mrageh |
Contributor
Author
|
@ronwsmith Thanks a lot, appreciate the merge and the update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I mentioned in #217, 1.0.x versions of
eventmachinemean that Puffing Billy cannot be used when dealing with resources over HTTP/2, but I see that the version ofeventmachinewas set back again in #212 due to compatibility issues withwatir. I want to use the latest version of Puffing Billy in order to get access to some of the new features, so I'm going to try bumpingeventmachineagain.All of the unit tests passed for me, once I made the small change here in
test_server.rb. This looks similar to the issue I described in #217 wherelocalhostwon't work, but127.0.0.1will.