Rescue LoadErrors during driver registration - #170
Merged
Merged
Conversation
reverts lib/billy/browsers/capybara.rb to correctly rescue from LoadError
| require driver rescue next | ||
| send("register_#{name}_driver") | ||
| begin | ||
| - require driver |
Collaborator
There was a problem hiding this comment.
Looks like you left the - in here from the old diff.
Contributor
|
Confirmed that fix works locally for me 👍 |
|
Came across this issue in my gem updates recently too, that looks like it does the original job once again since |
Contributor
|
Is it possible to add a test for this scenario as a follow-up PR to ensure we have this code coverage? 👍 |
|
I don't think so .. the failure is in missing a dependancy to begin with .. you'd literally need to test with some gems removed |
Collaborator
|
Releasing 0.9.1 right now. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reverts lib/billy/browsers/capybara.rb to correctly rescue from LoadError