Skip to content

doc: fix crypto changes list sorting - #66073

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:fix-lint-md
Sep 16, 2026
Merged

doc: fix crypto changes list sorting#66073
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:fix-lint-md

Conversation

@legendecas

@legendecas legendecas commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fix lint-md failures after #65881 landed on the main branch.

@nodejs-github-bot

nodejs-github-bot commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation. labels Sep 16, 2026
@legendecas

legendecas commented Sep 16, 2026

Copy link
Copy Markdown
Member Author

lint-md is failing on recent PRs like #66072 and #66068.

@legendecas
legendecas requested a review from aduh95 September 16, 2026 20:22
@aduh95 aduh95 added fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 16, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Commit Queue failed

   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
   ✖  This PR needs to wait 47 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✖  GitHub CI is still running

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output 
�[36m⠋�[39m Loading data for nodejs/node/pull/66073
�[36m⠋�[39m Loading data for nodejs/node/pull/66073
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/66073
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66073
�[36m⠋�[39m Getting comments from nodejs/node/pull/66073
�[36m⠋�[39m Getting commits from nodejs/node/pull/66073
✔  Done loading data for nodejs/node/pull/66073
----------------------------------- PR info ------------------------------------
Title      doc: fix crypto changes list sorting (#66073)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     legendecas:fix-lint-md -> nodejs:main
Labels     crypto, doc, fast-track, author ready, commit-queue
Commits    1
 - doc: fix crypto changes list sorting
Committers 1
 - Chengzhong Wu <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/66073
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/66073
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 16 Sep 2026 20:19:19 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/66073#pullrequestreview-5227962292
   ✔  - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/66073#pullrequestreview-5228287540
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/66073#pullrequestreview-5228689700
   ℹ  This PR is being fast-tracked
   ✖  This PR needs to wait 47 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✖  GitHub CI is still running
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

@pimterry pimterry added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 16, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 6f723ec into nodejs:main Sep 16, 2026
45 checks passed
@nodejs-github-bot

nodejs-github-bot commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Landed in 6f723ec

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 16, 2026
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Sep 16, 2026
@legendecas
legendecas deleted the fix-lint-md branch September 17, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@pimterry pimterry pimterry approved these changes
@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@legendecas @nodejs-github-bot @lpinca @pimterry @aduh95