build: derive V8_LOGGING_LEVEL from dcheck_always_on - #65744
Merged
Merged
Conversation
Signed-off-by: Joyee Cheung <[email protected]>
Collaborator
|
Review requested:
|
richardlau
approved these changes
Sep 2, 2026
Collaborator
Collaborator
Collaborator
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/77192/ ✔ Build data downloaded ℹ Existing CI run found: https://ci.nodejs.org/job/node-test-pull-request/77192/ ✖ Refusing to start a potentially duplicate CI job. Use the "Resume build" button in the Jenkins UI, or start a new CI manually.https://github.com/nodejs/node/actions/runs/34904456385 |
Collaborator
Collaborator
Collaborator
|
Landed in 2dd7e7b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unblocks #65161 because otherwise logging level defaults to 0, which means no message is printed, breaking the test added in #65589
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7705483