Skip to content

build: downgrade Intel macOS support to experimental - #65427

Open
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:x86_64-darwin-eol
Open

build: downgrade Intel macOS support to experimental#65427
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:x86_64-darwin-eol

Conversation

@aduh95

@aduh95 aduh95 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Following-up from #63931, we've established that Rosetta support (that we use to build universal binaries, i.e. that can be used for both aarch64-darwin and x86_64-darwin) will likely end during Node.js 27 lifetime, so it probably makes sense to stop shipping x86_64-darwin compatible official binaries as of Node.js 27.0.0-alpha.0.0.0.
If you're a Intel mac user, you'd need to rely on unofficial binaries – or greatly extend your machine lifetime by switching to Linux.

/cc @nodejs/build

Refs: nodejs/build#4317

@aduh95 aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 20, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/build
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. labels Aug 20, 2026
@richardlau richardlau mentioned this pull request Aug 20, 2026
Open
mcollina
mcollina approved these changes Aug 20, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sxa
sxa approved these changes Aug 26, 2026
View reviewed changes

@sxa sxa left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this in the last Release WG call and there were no objections.

If you're a Intel mac user, you'd need to rely on unofficial binaries

As long as no-one has an expectation that the unofficial-builds project will provide them. But that's not suggested in the change so LGTM!

or greatly extend your machine lifetime by switching to Linux.

Much better idea ;-) Although there's always docker/podman if people really get stuck I guess.

@codecov

codecov Bot commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.26%. Comparing base (ea4b37f) to head (b9a43a8).
⚠️ Report is 564 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65427      +/-   ##
==========================================
+ Coverage   90.11%   90.26%   +0.14%     
==========================================
  Files         752      789      +37     
  Lines      252321   271428   +19107     
  Branches    47443    51798    +4355     
==========================================
+ Hits       227387   244991   +17604     
- Misses      16228    16924     +696     
- Partials     8706     9513     +807

see 322 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 mentioned this pull request Sep 16, 2026
Open
mcollina
mcollina approved these changes Sep 17, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 17, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 17, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Commit Queue failed

   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
   ✖  No Jenkins CI runs detected

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output 
�[36m⠋�[39m Loading data for nodejs/node/pull/65427
�[36m⠋�[39m Loading data for nodejs/node/pull/65427
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/65427
�[36m⠋�[39m Getting reviews from nodejs/node/pull/65427
�[36m⠋�[39m Getting comments from nodejs/node/pull/65427
�[36m⠋�[39m Getting commits from nodejs/node/pull/65427
✔  Done loading data for nodejs/node/pull/65427
----------------------------------- PR info ------------------------------------
Title      build: downgrade Intel macOS support to experimental (#65427)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:x86_64-darwin-eol -> nodejs:main
Labels     doc, semver-major, build, commit-queue
Commits    2
 - build: downgrade Intel macOS support to experimental
 - Revert "build: update Makefile to support fat binary"
Committers 1
 - Antoine du Hamel <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/65427
Refs: https://github.com/nodejs/build/issues/4317
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65427
Refs: https://github.com/nodejs/build/issues/4317
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 20 Aug 2026 12:52:27 GMT
   ✔  Approvals: 10
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/65427#pullrequestreview-4982920351
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/65427#pullrequestreview-4982976420
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/65427#pullrequestreview-5229201744
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/65427#pullrequestreview-4983366290
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/65427#pullrequestreview-4983657455
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/65427#pullrequestreview-4985019598
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65427#pullrequestreview-5232691765
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/65427#pullrequestreview-4993381485
   ✔  - Stewart X Addison (@sxa): https://github.com/nodejs/node/pull/65427#pullrequestreview-5032537983
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/65427#pullrequestreview-5224496447
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@richardlau richardlau richardlau approved these changes
@sxa sxa sxa approved these changes
@legendecas legendecas legendecas approved these changes
@Renegade334 Renegade334 Renegade334 approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. doc Issues and PRs related to Node.js documentation. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.