Skip to content

benchmark: add dotenv benchmark - #54278

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
avivkeller:dotenv-bench
Sep 18, 2024
Merged

benchmark: add dotenv benchmark#54278
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
avivkeller:dotenv-bench

Conversation

@avivkeller

@avivkeller avivkeller commented Aug 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This PR adds a benchmark for dotenv file parsing:

util/parse-env.js
util/parse-env.js n=30000: 57,033.66385773717

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. label Aug 9, 2024
@avivkeller avivkeller added the dotenv Issues and PRs related to .env file parsing. label Aug 9, 2024
H4ad
H4ad reviewed Aug 10, 2024
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @anonrig This method is something that we can benchmark? Does it have any form of caching or something that could affect the benchmark?

Comment thread benchmark/misc/dotenv.js Outdated
@avivkeller avivkeller added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Aug 10, 2024
@avivkeller
avivkeller requested a review from anonrig August 23, 2024 18:55
@avivkeller

ghost commented Sep 4, 2024

Copy link
Copy Markdown
Member Author

@anonrig would you mind reviewing this PR?

anonrig
anonrig reviewed Sep 4, 2024
View reviewed changes
Comment thread benchmark/misc/dotenv.js Outdated
anonrig
anonrig reviewed Sep 4, 2024
View reviewed changes
Comment thread benchmark/misc/dotenv.js Outdated
Comment thread benchmark/misc/dotenv.js Outdated
anonrig
anonrig reviewed Sep 4, 2024
View reviewed changes
Comment thread benchmark/util/parse-env.js Outdated
@avivkeller

ghost commented Sep 10, 2024

Copy link
Copy Markdown
Member Author

(Sorry @jasnell - only meant to request @anonrig 😅 )

@avivkeller

ghost commented Sep 17, 2024

Copy link
Copy Markdown
Member Author

Can this land?

@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 18, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 18, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 53cba82 into nodejs:main Sep 18, 2024
@nodejs-github-bot

ghost commented Sep 18, 2024

Copy link
Copy Markdown
Collaborator

Landed in 53cba82

@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
@marco-ippolito marco-ippolito mentioned this pull request Nov 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@H4ad H4ad H4ad approved these changes
@jasnell jasnell Awaiting requested review from jasnell

Assignees

No one assigned

Labels

benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. commit-queue-squash PRs the Commit Queue should land as one squashed commit. dotenv Issues and PRs related to .env file parsing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@avivkeller @nodejs-github-bot @jasnell @anonrig @H4ad