tools: automate gyp-next update - #52014
Merged
nodejs-github-bot merged 2 commits intoMar 11, 2024
Merged
Conversation
Collaborator
|
Review requested:
|
legendecas
approved these changes
Mar 8, 2024
Co-authored-by: Chengzhong Wu <[email protected]>
lpinca
approved these changes
Mar 8, 2024
2 tasks
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/52014 ✔ Done loading data for nodejs/node/pull/52014 ----------------------------------- PR info ------------------------------------ Title tools: automate gyp-next update (#52014) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/automate-gyp-next-update -> nodejs:main Labels meta, tools, author ready Commits 2 - tools: automate gyp-next update - Update tools/dep_updaters/update-gyp-next.sh Committers 2 - marco-ippolito - GitHub PR-URL: https://github.com/nodejs/node/pull/52014 Reviewed-By: Chengzhong Wu Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52014 Reviewed-By: Chengzhong Wu Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 08 Mar 2024 14:58:56 GMT ✔ Approvals: 2 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/52014#pullrequestreview-1925400170 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52014#pullrequestreview-1925680180 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52014 From https://github.com/nodejs/node * branch refs/pull/52014/merge -> FETCH_HEAD ✔ Fetched commits as 328642bbb98d..23d99af30099 -------------------------------------------------------------------------------- [main f2ddbe797f] tools: automate gyp-next update Author: marco-ippolito Date: Fri Mar 8 15:57:59 2024 +0100 2 files changed, 75 insertions(+) create mode 100755 tools/dep_updaters/update-gyp-next.sh [main c5c0fe38f0] Update tools/dep_updaters/update-gyp-next.sh Author: Marco Ippolito Date: Fri Mar 8 18:56:13 2024 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/8231189376 |
Collaborator
|
Landed in cde37e7 |
marco-ippolito
added a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52014 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
marco-ippolito
added a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52014 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
automates gyp-next update: #52011