Skip to content

src: turn ROUND_UP into an inline function - #25743

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:round-up
Closed

src: turn ROUND_UP into an inline function#25743
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:round-up

Conversation

@addaleax

@addaleax addaleax commented Jan 27, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2407/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. labels Jan 27, 2019
@addaleax

addaleax commented Jan 29, 2019

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20410/

@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 29, 2019
@addaleax

addaleax commented Jan 30, 2019

Copy link
Copy Markdown
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20445/

@addaleax

addaleax commented Jan 30, 2019

Copy link
Copy Markdown
Member Author

Landed in 6f217e7

@addaleax addaleax closed this Jan 30, 2019
@addaleax
addaleax deleted the round-up branch January 30, 2019 22:42
pull Bot pushed a commit to shakir-abdo/node that referenced this pull request Jan 30, 2019
@addaleax
src: turn ROUND_UP into an inline function
6f217e7 
PR-URL: nodejs#25743
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
addaleax added a commit that referenced this pull request Jan 30, 2019
@addaleax
src: turn ROUND_UP into an inline function
d9c2690 
PR-URL: #25743
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
+1 more reviewer
@TimothyGu TimothyGu TimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax @nodejs-github-bot @bnoordhuis @jasnell @TimothyGu @cjihrig