-
-
Notifications
You must be signed in to change notification settings - Fork 37.1k
build: lint under make test? #58606
Copy link
Copy link
Closed
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.
Description
Activity
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.
The documentation, and indeed makefile comments, still indicate that linters are run under the
make testtarget. In fact, this behaviour disappeared at some point (seemingly a combination of #19324 and #35708), although this doesn't appear to have been intentional.Should this behaviour be restored, or should the documentation be updated?
cc: @joyeecheung