Skip to content

Commit 900fae0

Browse files
jasnelladuh95
jasnell
authored and
aduh95
committed
test: split test-bench-cli to try deflaking it
I believe the test-bench-cli flakes were just because the one file was doing too much and on some architectures was taking too long to complete. This splits up the file. At the very least, if there's still a flake in here, the smaller, more focused files should help narrow it down Signed-off-by: James M Snell <[email protected]> PR-URL: #65919 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
1 parent b4a7cd3 commit 900fae0

5 files changed

Lines changed: 547 additions & 421 deletions

File tree

‎test/parallel/test-bench-cli-arguments.js‎

Lines changed: 78 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
1+
'use strict';
2+
3+
const common = require('../common');
4+
const assert = require('assert');
5+
const { spawnSync } = require('child_process');
6+
7+
const spawnTimeout = common.platformTimeout(30_000);
8+
9+
function spawnNode(args, options = undefined) {
10+
const result = spawnSync(process.execPath, args, {
11+
__proto__: null,
12+
encoding: 'utf8',
13+
timeout: spawnTimeout,
14+
...options,
15+
});
16+
assert.ifError(result.error);
17+
assert.strictEqual(result.signal, null);
18+
return result;
19+
}
20+
21+
function spawnBench(args, options = undefined) {
22+
return spawnNode(['--no-warnings', '--bench', ...args], options);
23+
}
24+
25+
for (const { args, message } of [
26+
{
27+
args: ['--bench-isolation=invalid', 'unused.js'],
28+
message: /invalid value for --bench-isolation/,
29+
},
30+
{
31+
args: ['--bench-samples=0', 'unused.js'],
32+
message: /--bench-samples must be greater than 0/,
33+
},
34+
{
35+
args: ['--bench-warmup=4294967296', 'unused.js'],
36+
message: /--bench-warmup.*out of range/,
37+
},
38+
{
39+
args: ['--bench-samples=2x', 'unused.js'],
40+
message: /invalid value for --bench-samples/,
41+
},
42+
{
43+
args: ['--bench-warmup=abc', 'unused.js'],
44+
message: /invalid value for --bench-warmup/,
45+
},
46+
{
47+
args: ['--bench-name-pattern=[', 'unused.js'],
48+
message: /invalid regular expression/,
49+
},
50+
{
51+
args: ['--eval=1', 'unused.js'],
52+
message: /either --bench or --eval can be used, not both/,
53+
},
54+
{
55+
args: ['--interactive', 'unused.js'],
56+
message: /either --bench or --interactive can be used, not both/,
57+
},
58+
{
59+
args: ['--watch', 'unused.js'],
60+
message: /either --bench or --watch can be used, not both/,
61+
},
62+
{
63+
args: ['--watch-path=.', 'unused.js'],
64+
message: /either --bench or --watch can be used, not both/,
65+
},
66+
{
67+
args: ['--check', 'unused.js'],
68+
message: /either --bench or --check can be used, not both/,
69+
},
70+
{
71+
args: ['--test', 'unused.js'],
72+
message: /either --bench or --test can be used, not both/,
73+
},
74+
]) {
75+
const result = spawnBench(args);
76+
assert.notStrictEqual(result.status, 0);
77+
assert.match(result.stderr, message);
78+
}

‎test/parallel/test-bench-cli-backpressure.js‎

Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,62 @@
1+
'use strict';
2+
3+
const common = require('../common');
4+
const assert = require('assert');
5+
const { spawnSync } = require('child_process');
6+
const fixtures = require('../common/fixtures');
7+
8+
const spawnTimeout = common.platformTimeout(30_000);
9+
10+
function spawnNode(args, options = undefined) {
11+
const result = spawnSync(process.execPath, args, {
12+
__proto__: null,
13+
encoding: 'utf8',
14+
timeout: spawnTimeout,
15+
...options,
16+
});
17+
assert.ifError(result.error);
18+
assert.strictEqual(result.signal, null);
19+
return result;
20+
}
21+
22+
function spawnBench(args, options = undefined) {
23+
return spawnNode(['--no-warnings', '--bench', ...args], options);
24+
}
25+
26+
function parseRecords(result) {
27+
assert.strictEqual(result.stderr, '');
28+
return parseOutput(result.stdout);
29+
}
30+
31+
function parseOutput(output) {
32+
return output.trim().split('\n').map((line) => JSON.parse(line));
33+
}
34+
35+
{
36+
const result = spawnBench([
37+
`--bench-reporter=${fixtures.fileURL('bench-runner/slow-reporter.cjs')}`,
38+
fixtures.path('bench-runner/many-records.cjs'),
39+
]);
40+
assert.strictEqual(result.status, 0);
41+
assert.strictEqual(result.stderr, '');
42+
const report = JSON.parse(result.stdout);
43+
assert.strictEqual(report.samples, 30);
44+
assert.strictEqual(report.stdout,
45+
Array.from({ length: 30 }, (_, i) => `${i}\n`).join(''));
46+
}
47+
48+
{
49+
const result = spawnBench([
50+
'--bench-reporter=json',
51+
fixtures.path('bench-runner/acknowledged-records.mjs'),
52+
]);
53+
assert.strictEqual(result.status, 0);
54+
assert.strictEqual(result.stderr, '');
55+
const records = parseRecords(result);
56+
const diagnostics = records.filter(
57+
({ type }) => type === 'bench:diagnostic');
58+
assert.strictEqual(diagnostics.length, 32);
59+
assert(diagnostics.every(
60+
({ data }) => /^acknowledged 10\d{3}$/.test(data.message)));
61+
assert.strictEqual(records.at(-1).data.success, true);
62+
}

0 commit comments

Comments
 (0)