Conversation
Browser::remove joined the raw MPD-supplied item path with mpd_music_dir via realPath without filtering '..' segments, then called fs::remove. A remote or compromised MPD server presenting a directory or song whose path contains '..' could cause deletion of an arbitrary user-owned file or directory outside mpd_music_dir when the user pressed delete in the MPD browser. The confirmation prompt displays only the basename, so the traversal was hidden from the user. Add a local normalizePath helper in the anonymous namespace that collapses '.' and '..' segments (relative paths cannot escape above their root, absolute paths keep their leading slash) and apply it to the MPD-supplied path inside realPath before joining with mpd_music_dir. Legitimate relative paths are unchanged; only traversal segments are removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser::remove joined the raw MPD-supplied item path with mpd_music_dir
via realPath without filtering '..' segments, then called fs::remove. A
remote or compromised MPD server presenting a directory or song whose
path contains '..' could cause deletion of an arbitrary user-owned file
or directory outside mpd_music_dir when the user pressed delete in the
MPD browser. The confirmation prompt displays only the basename, so the
traversal was hidden from the user.
Add a local normalizePath helper in the anonymous namespace that
collapses '.' and '..' segments (relative paths cannot escape above
their root, absolute paths keep their leading slash) and apply it to the
MPD-supplied path inside realPath before joining with mpd_music_dir.
Legitimate relative paths are unchanged; only traversal segments are
removed.