Replace non-standard Variable-Length Arrays with std::vector in Visualizer - #654
Merged
arybczak merged 1 commit intoJun 25, 2026
Merged
Conversation
Collaborator
|
Thanks 👍 |
kda
pushed a commit
to kda/ncmpcpp
that referenced
this pull request
Sep 8, 2026
…cmpcpp#654) Co-authored-by: Devon Kirk <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally included the commit for my other PR in this one, so I had to remake it, sorry.
In
Visualizer::update()with stereo mode enabled, the code uses C99 Variable-Length Arrays (VLAs) to allocate audio buffers on the stack:VLAs aren't part of the C++ standard. Buffer sizes range from ~29 KB per buffer (wave modes) to ~57 KB per buffer (spectrum mode), totaling ~114 KB for both. This approaches or exceeds default stack limits on some platforms (256 KB on Windows, smaller on embedded), potentially causing silent stack overflow crashes.
Using
std::vectorinstead allocates on the heap and is standard C++:Pass buffers to drawing functions using
.data():(this->*drawStereo)(buf_left.data(), buf_right.data(), chan_samples, half_height);Also adds
#include <vector>.