Conversation
arybczak
reviewed
Jun 25, 2026
| { | ||
| virtual const char *name() const override { return "azlyrics.com"; } | ||
| protected: | ||
| virtual const char *regex() const override { return "(?s)<!-- Usage of azlyrics\\.com content.*?-->(.*?)</div>"; } |
Collaborator
There was a problem hiding this comment.
Yeah, ncmpcpp used to have azlyrics fetcher, but matching on the message Usage of azlyrics.com content by any third-party lyrics provider is prohibited by our licensing agreement. Sorry about that to fetch lyrics for a third party provider (i.e. ncmpcpp) is not great, don't you think? That's why I removed it in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding two new lyrics sources from:
azlyrics.com and
darklyrics.com: A popular source for metal. Since DarkLyrics hosts full albums on a single page, I added a custom fetch and postProcess override to regex-match the specific song title and extract only the relevant lyrics from the album page.
Note: I am new to C++ and programming in general. Used an AI assistant (Gemini 3) to help me writing regex and structure the DarkLyricsFetcher logic. I have tested it locally and seem to fetch lyrics without issues. Thank you!