fix: Treated localized extension names as literal filename text - #3832
Open
Hanabi9248 wants to merge 2 commits into
Open
Hanabi9248 wants to merge 2 commits into
Hanabi9248 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A localized extension named
Price $& Trackerbuilds asprice_msg_name_tracker-1.0.zip: the replacement string expands$&back to{name}, which is then resolved against the original manifest. Likewise,Edition {version}substitutes the manifest version, andTools/Kitfails filename validation.Sanitize the localized name before inserting it into the filename template, using a replacement callback. This gives localized names the same filename treatment as ordinary manifest names and keeps their contents from being interpreted as template syntax.
All three regressions exercise actual package builds and fail before the change. On Windows with Node 24.19.0, the build and full test suite pass (585 passing, 3 pending), as do Prettier and ESLint for both changed files.