Skip to content

Removed silverman and kde warnings #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kala-moz merged 1 commit into from
Aug 18, 2026
Merged

Removed silverman and kde warnings #1082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/__tests__/CompareResults/RevisionRowExpandable.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,11 @@ describe('RevisionRowExpandable for mann-whitney-u testVersion', () => {
/>,
);

const expectedWarning1 =
'Less than 2 datapoints or no standard variance for a meaningful fit Kernel Density Estimator (KDE) with an ISJ bandwidth to Base.';
const shapiroWarning =
'Shapiro-Wilk test cannot be run on Base with fewer than 3 data points.';
const shapiroWarning2 =
'Shapiro-Wilk test cannot be run on New with fewer than 3 data points.';

const warning1 = await screen.findByText(expectedWarning1);
expect(warning1).toBeInTheDocument();
const swWarning = await screen.findByText(shapiroWarning);
expect(swWarning).toBeInTheDocument();
const swWarning2 = await screen.findByText(shapiroWarning2);
Expand Down
14 changes: 0 additions & 14 deletions src/__tests__/utils/fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,6 @@ const getTestData = () => {

is_new_better: null,
direction_of_change: 'improvement',
kde_warnings: [],
},
{
base_rev: 'coconut',
Expand Down Expand Up @@ -543,7 +542,6 @@ const getTestData = () => {
is_new_better: null,
direction_of_change: 'regression',
shapiro_wilk_test_base: null,
kde_warnings: [],
},
{
base_rev: 'coconut',
Expand Down Expand Up @@ -627,7 +625,6 @@ const getTestData = () => {
},
is_new_better: null,
direction_of_change: null,
kde_warnings: [],
},
{
base_rev: 'coconut',
Expand Down Expand Up @@ -710,7 +707,6 @@ const getTestData = () => {
},
is_new_better: null,
direction_of_change: null,
kde_warnings: [],
},
];

Expand Down Expand Up @@ -1301,11 +1297,6 @@ const getTestData = () => {
effect_size: '',
cles_explanation: '',
},
silverman_warnings: [],
kde_warnings: [
'Less than 2 datapoints or no standard variance for a meaningful fit Kernel Density Estimator (KDE) with an ISJ bandwidth to Base.',
'Less than 2 datapoints or no standard variance for a meaningful fit Kernel Density Estimator (KDE) with an ISJ bandwidth to New.',
],
new_is_better: null,
};

Expand Down Expand Up @@ -1398,7 +1389,6 @@ const getTestData = () => {
},
cliffs_delta: 0.02,
cliffs_interpretation: 'negligible',
kde_warnings: [],
cles: {
cles: 0.6,
cles_direction: '',
Expand Down Expand Up @@ -1506,7 +1496,6 @@ const getTestData = () => {
effect_size: '',
cles_explanation: '',
},
kde_warnings: [],
is_new_better: null,
direction_of_change: 'improvement',
},
Expand Down Expand Up @@ -1596,7 +1585,6 @@ const getTestData = () => {
effect_size: '',
cles_explanation: '',
},
kde_warnings: [],
is_new_better: null,
direction_of_change: null,
},
Expand Down Expand Up @@ -1686,7 +1674,6 @@ const getTestData = () => {
effect_size: '',
cles_explanation: '',
},
kde_warnings: [],
is_new_better: null,
direction_of_change: null,
},
Expand Down Expand Up @@ -1776,7 +1763,6 @@ const getTestData = () => {
effect_size: '',
cles_explanation: '',
},
kde_warnings: [],
is_new_better: null,
direction_of_change: null,
},
Expand Down
2 changes: 0 additions & 2 deletions src/components/CompareResults/StatisticsWarnings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ export const StatisticsWarnings = ({
// Combine all warnings into a single list
const warnings: string[] = [
...(result?.shapiro_wilk_warnings ?? []),
...(result?.silverman_warnings ?? []),
...(result?.ks_warning ? [result?.ks_warning] : []),
...(result?.kde_warnings ?? []),
];
return (
<>
Expand Down
2 changes: 0 additions & 2 deletions src/types/state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,6 @@ export type MannWhitneyResultsItem = {
cliffs_delta: number;
cliffs_interpretation: string;
cles?: CLESItem; // CLES: Common Language Effect Size, statistical effect interpretation from Mann-Whitney U
kde_warnings: string[];
silverman_warnings?: string[] | null; // silverman warnings about multimodal data
is_new_better: boolean | null; // is the new revision better than the base revision
direction_of_change: 'no change' | 'improvement' | 'regression' | null;
new_is_better: boolean | null;
Expand Down