Skip to content

Fix decryption of AES-256 revision 5 PDFs with non-ASCII passwords - #21580

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:issue21579
Jul 16, 2026
Merged

Fix decryption of AES-256 revision 5 PDFs with non-ASCII passwords#21580
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:issue21579

Conversation

@calixteman

@calixteman calixteman commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

It fixes #21579.

@calixteman
calixteman requested a review from Snuffleupagus July 16, 2026 12:01
@codecov-commenter

codecov-commenter commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.75%. Comparing base (e39b239) to head (5f09f79).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #21580   +/-   ##
=======================================
  Coverage   89.75%   89.75%           
=======================================
  Files         262      262           
  Lines       66740    66740           
=======================================
  Hits        59902    59902           
  Misses       6838     6838
Flag Coverage Δ
browsertest 66.54% <100.00%> (-0.01%) ⬇️
fonttest 9.04% <ø> (ø)
integrationtest 69.25% <100.00%> (+<0.01%) ⬆️
unittest 57.35% <100.00%> (-0.01%) ⬇️
unittestcli 56.33% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus

Snuffleupagus commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

/botio browsertest

@moz-tools-bot

moz-tools-bot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9c2200a4a02af9e/output.txt

@moz-tools-bot

moz-tools-bot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/07b328730fda4c2/output.txt

@moz-tools-bot

moz-tools-bot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/9c2200a4a02af9e/output.txt

Total script time: 18.60 mins

  • Regression tests: Passed

@moz-tools-bot

moz-tools-bot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/07b328730fda4c2/output.txt

Total script time: 27.09 mins

  • Regression tests: FAILED
  errors: 6

Image differences available at: http://54.193.163.58:8877/07b328730fda4c2/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus approved these changes Jul 16, 2026
View reviewed changes

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the PDF document as an eq, or at least load, ref-test as well?

r=me, thanks.

@calixteman
calixteman merged commit e909f1f into mozilla:master Jul 16, 2026
20 of 21 checks passed
@calixteman

calixteman commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

/botio makeref

@moz-tools-bot

moz-tools-bot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e229c4a10b773ab/output.txt

@moz-tools-bot

moz-tools-bot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7a27115a4fdee6c/output.txt

@moz-tools-bot

moz-tools-bot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/e229c4a10b773ab/output.txt

Total script time: 18.17 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot

moz-tools-bot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/7a27115a4fdee6c/output.txt

Total script time: 25.73 mins

  • Make references: Passed
  • Check references: Passed

@github-actions github-actions Bot mentioned this pull request Aug 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: AES-256 revision 5 PDFs with a non-ASCII password fail to decrypt

4 participants

@calixteman @codecov-commenter @Snuffleupagus @moz-tools-bot