Fix AcroForm appearance resources when merging pages - #21577
Merged
timvandermeij merged 1 commit intoJul 16, 2026
Merged
timvandermeij merged 1 commit into
timvandermeij merged 1 commit into
Conversation
Merging pages with conflicting AcroForm /DR must inline the resources each field's appearance relies on, since only one /DR survives in the output. That fixup: - resolved the appearance /Resources ref against the source document's xref instead of the merged one, so the lookup failed and merging threw (null.has(...)); - skipped checkbox/radio widgets, whose /AP /N is a sub-dictionary of appearance states rather than a single stream; - threw on a non-dictionary /Resources (e.g. a stray name) instead of falling back to the default resources.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21577 +/- ##
==========================================
+ Coverage 89.74% 89.77% +0.02%
==========================================
Files 262 262
Lines 66751 66746 -5
==========================================
+ Hits 59907 59921 +14
+ Misses 6844 6825 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Jul 16, 2026
Collaborator
|
Looks good. Thank you for fixing this and including more tests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging pages with conflicting AcroForm /DR must inline the resources each field's appearance relies on, since only one /DR survives in the output. That fixup: