Dict object improvements. Performance. - #214
Merged
Merged
Conversation
Contributor
|
This looks fine to me. Andreas? |
Contributor
Author
|
Woops, not fine. Minor typo, let me fix that. |
Contributor
Author
|
Fixed with latest commit 42cdf6b |
Contributor
|
Shaon is working on fixing the glyph issues. Can you change the pull request back to 42cdf6b so you don't collide with him? I want to pull the perf work. |
Contributor
|
I will merge and backout the last changeset manually. Thanks for the patch! |
andreasgal
added a commit
that referenced
this pull request
Jul 8, 2011
Dict object improvements. Performance.
Contributor
Author
|
Yea, sorry I was only commiting to my fork, didn't mean to include the later commits..? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this is the simple changes i made to the Dict object which seems to speed up thing x2 - x5 and improve the code-quality a bit.
Hope this is any use for you guys!