Avoid pattern creation with some basic gradients - #20525
Conversation
Some gradients are represented as patterns in PDF.js, because they mustn't be affected by the current transform. But in most of the cases, the gradient is attached to the origin and the current transform is very basic (dilatation + orthogonal + translation). In those cases, we can avoid creating the pattern because the gradient is transformed into another gradient when the inverse transform is applied.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ae728adbff06b23/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/5dc06080127391b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ae728adbff06b23/output.txt Total script time: 40.83 mins
Image differences available at: http://54.241.84.105:8877/ae728adbff06b23/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5dc06080127391b/output.txt Total script time: 76.93 mins
Image differences available at: http://54.193.163.58:8877/5dc06080127391b/reftest-analyzer.html#web=eq.log |
timvandermeij
left a comment
There was a problem hiding this comment.
r=me; thank you for improving this!
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9f2ede11b85effb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9745d0bad6b933c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9f2ede11b85effb/output.txt Total script time: 18.78 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/9745d0bad6b933c/output.txt Total script time: 31.98 mins
|
Some gradients are represented as patterns in PDF.js, because they mustn't be affected by the current transform. But in most of the cases, the gradient is attached to the origin and the current transform is very basic (dilatation + orthogonal + translation). In those cases, we can avoid creating the pattern because the gradient is transformed into another gradient when the inverse transform is applied.