Skip to content

Change the sidebar for a views manager - #20495

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:new_sidebar
Dec 15, 2025
Merged

Change the sidebar for a views manager#20495
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:new_sidebar

Conversation

@calixteman

@calixteman calixteman commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Update the styles and HTML to reflect the new views manager concept. For now, nothing about split/merge functionality is implemented or visible. The new styles for the outline, attachments, and layers will be added later.

The thumbnail view is now accessible with the keyboard.

@calixteman
calixteman requested a review from a team as a code owner December 9, 2025 21:20
flodolo
flodolo reviewed Dec 10, 2025
View reviewed changes
Comment thread l10n/en-US/viewer.ftl Outdated
Comment thread l10n/en-US/viewer.ftl
Comment thread l10n/en-US/viewer.ftl Outdated
@calixteman
calixteman force-pushed the new_sidebar branch 2 times, most recently from 97fee23 to 86b3dbf Compare December 10, 2025 14:42
flodolo
flodolo reviewed Dec 10, 2025
View reviewed changes
Comment thread l10n/en-US/viewer.ftl Outdated
@calixteman
calixteman force-pushed the new_sidebar branch 2 times, most recently from e250fad to e023ab9 Compare December 11, 2025 17:00
@timvandermeij

timvandermeij commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

/botio-linux preview

@moz-tools-bot

moz-tools-bot commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0d737d63cc5288b/output.txt

@moz-tools-bot

moz-tools-bot commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/0d737d63cc5288b/output.txt

Total script time: 0.96 mins

Published

@timvandermeij

timvandermeij commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

/botio integrationtest

@moz-tools-bot

moz-tools-bot commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c2376be8dbd4d13/output.txt

@moz-tools-bot

moz-tools-bot commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/923731d8d161bd8/output.txt

@moz-tools-bot

moz-tools-bot commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/923731d8d161bd8/output.txt

Total script time: 20.20 mins

  • Integration Tests: Passed

@moz-tools-bot

moz-tools-bot commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c2376be8dbd4d13/output.txt

Total script time: 43.77 mins

  • Integration Tests: FAILED

timvandermeij
timvandermeij reviewed Dec 13, 2025
View reviewed changes
Comment thread test/integration/thumbnail_view_spec.mjs
Comment thread web/views_manager.css Outdated
Comment thread web/views_manager.css
Comment thread web/views_manager.css
@calixteman
Change the sidebar for a views manager
2367196 
Update the styles and HTML to reflect the new views manager concept.
For now, nothing about split/merge functionality is implemented or visible.
The new styles for the outline, attachments, and layers will be added later.

The thumbnail view is now accessible with the keyboard.
@calixteman

calixteman commented Dec 15, 2025

Copy link
Copy Markdown
Contributor Author

/botio integrationtest

@moz-tools-bot

moz-tools-bot commented Dec 15, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ac194afe3cae9c1/output.txt

@moz-tools-bot

moz-tools-bot commented Dec 15, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/68bb631c26b8157/output.txt

@moz-tools-bot

moz-tools-bot commented Dec 15, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/68bb631c26b8157/output.txt

Total script time: 20.23 mins

  • Integration Tests: Passed

@moz-tools-bot

moz-tools-bot commented Dec 15, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/ac194afe3cae9c1/output.txt

Total script time: 42.46 mins

  • Integration Tests: Passed

@calixteman
calixteman merged commit cdf34b6 into mozilla:master Dec 15, 2025
10 checks passed
@calixteman
calixteman deleted the new_sidebar branch December 15, 2025 17:45
@Rob--W Rob--W mentioned this pull request Feb 26, 2026
Closed
@Snuffleupagus Snuffleupagus mentioned this pull request Feb 26, 2026
Merged
@Snuffleupagus Snuffleupagus mentioned this pull request May 14, 2026
Closed
@WASIDJ WASIDJ mentioned this pull request Jun 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij left review comments
@flodolo flodolo flodolo approved these changes

Assignees

No one assigned

Labels

viewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@calixteman @timvandermeij @moz-tools-bot @flodolo