Display widget signature by calixteman · Pull Request #13214 · mozilla/pdf.js

calixteman · 2021-04-10T15:04:47Z

but don't validate them for now;
Firefox will display a bar to warn that the signature validation is not supported (see https://bugzilla.mozilla.org/show_bug.cgi?id=854315)
almost all (all ?) pdf readers display signatures;
validation is done in edge but for now it's behind a pref.

Snuffleupagus

Do we have any existing reference-tests which will cover these changes? If not, can you please add one?

(We probably want to defer this to a follow-up, but we should perhaps consider if/how we want to display a warning in the GENERIC-viewer as well.)

Snuffleupagus

r=me, with passing tests; thank you!

calixteman · 2021-04-10T16:33:10Z

/botio test

pdfjsbot · 2021-04-10T16:33:11Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/edf3a33c94c93e2/output.txt

pdfjsbot · 2021-04-10T16:33:11Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/8c432dcf69fb386/output.txt

pdfjsbot · 2021-04-10T16:58:16Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/8c432dcf69fb386/output.txt

Total script time: 25.07 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/8c432dcf69fb386/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-04-10T17:01:44Z

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/edf3a33c94c93e2/output.txt

Total script time: 28.55 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/edf3a33c94c93e2/reftest-analyzer.html#web=eq.log

timvandermeij · 2021-04-10T17:13:10Z

@calixteman Unfortunately I don't have enough access rights to be able to comment on the upstream patch in Phabricator, but I found a bug in there: } else if ("signatures") { always evaluates to true. I think you meant } else if (featureId === "signatures") { there, but the featureId === part fell off.

- but don't validate them for now; - Firefox will display a bar to warn that the signature validation is not supported (see https://bugzilla.mozilla.org/show_bug.cgi?id=854315) - almost all (all ?) pdf readers display signatures; - validation is done in edge but for now it's behind a pref.

timvandermeij · 2021-04-10T17:27:56Z

/botio-linux preview

pdfjsbot · 2021-04-10T17:27:57Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/f90cd937a5806b8/output.txt

pdfjsbot · 2021-04-10T17:32:21Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/f90cd937a5806b8/output.txt

Total script time: 4.39 mins

Published

Viewer: http://54.67.70.0:8877/f90cd937a5806b8/web/viewer.html
Viewer (legacy): http://54.67.70.0:8877/f90cd937a5806b8/legacy/web/viewer.html

timvandermeij · 2021-04-10T17:35:47Z

Looks good to me too; thanks! Let's do this, especially since we can now properly warn users about the missing validation and this has been requested very often.

/botio makeref

pdfjsbot · 2021-04-10T17:35:48Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/a96e7f77d1d93b3/output.txt

pdfjsbot · 2021-04-10T17:35:49Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 1

Live output at: http://3.101.106.178:8877/6767816e411abfa/output.txt

pdfjsbot · 2021-04-10T17:58:38Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/a96e7f77d1d93b3/output.txt

Total script time: 22.81 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2021-04-10T18:06:06Z

From: Bot.io (Windows)

Success

Full output at http://3.101.106.178:8877/6767816e411abfa/output.txt

Total script time: 26.24 mins

Lint: Passed
Make references: Passed
Check references: Passed

CetinSert · 2021-04-11T06:40:48Z

@calixteman Can this be implemented for the SVG renderer as well?

Snuffleupagus · 2021-04-11T08:35:15Z

Can this be implemented for the SVG renderer as well?

Please note #13219 (comment)

…s not supported in PDF files r=bdahl DONTBUILD Thanks to PR: mozilla/pdf.js#13214 signatures in PDF will be displayed but they won't be validated. So display a banner to warn user about that. Differential Revision: https://phabricator.services.mozilla.com/D111540

stephanrauh · 2021-04-22T18:56:22Z

@calixteman @timvandermeij Awesome! You've merged the PR roughly the same time when you've published the new version, so I'd like to ask if this is a feature of version 2.9? Or did you already include it in version 2.8?

Snuffleupagus · 2021-04-22T20:01:38Z

You've merged the PR roughly the same time when you've published the new version, so I'd like to ask if this is a feature of version 2.9? Or did you already include it in version 2.8?

This patch is not included in any official release yet, since it landed after the last release; see https://github.com/mozilla/pdf.js/releases and compare the date of this patch being merged with the date of the latest release :-)

Also, please keep in mind that all PDF.js versions consist of three numbers, e.g. the current pre-release is 2.8.335 and the stable release is 2.7.570. (In order to reduce confusion, it's always best to use full version numbers.)

…s not supported in PDF files r=bdahl DONTBUILD Thanks to PR: mozilla/pdf.js#13214 signatures in PDF will be displayed but they won't be validated. So display a banner to warn user about that. Differential Revision: https://phabricator.services.mozilla.com/D111540

Snuffleupagus requested changes Apr 10, 2021

View reviewed changes

Comment thread l10n/en-US/chrome.properties Outdated

Comment thread src/core/annotation.js Outdated

Comment thread src/core/document.js Outdated

Comment thread web/app.js Outdated

calixteman force-pushed the signatures branch 2 times, most recently from 31c3384 to 5bd4b8d Compare April 10, 2021 15:46

Snuffleupagus reviewed Apr 10, 2021

View reviewed changes

Comment thread test/unit/api_spec.js

calixteman force-pushed the signatures branch from 5bd4b8d to 47b4262 Compare April 10, 2021 16:09

Snuffleupagus approved these changes Apr 10, 2021

View reviewed changes

timvandermeij added the annotations label Apr 10, 2021

timvandermeij reviewed Apr 10, 2021

View reviewed changes

Comment thread test/test_manifest.json

calixteman force-pushed the signatures branch from 47b4262 to d340141 Compare April 10, 2021 16:57

calixteman force-pushed the signatures branch from d340141 to 5875ebb Compare April 10, 2021 17:13

timvandermeij approved these changes Apr 10, 2021

View reviewed changes

timvandermeij merged commit d9d626a into mozilla:master Apr 10, 2021

timvandermeij mentioned this pull request Apr 10, 2021

Implement a warning for unvalidated digital signatures in the generic viewer #13215

Closed

sylvestre reviewed Apr 10, 2021

View reviewed changes

Comment thread l10n/en-US/chrome.properties

CetinSert mentioned this pull request Apr 11, 2021

Display widget signature in SVG #13219

Closed

ralfhauser mentioned this pull request Apr 12, 2021

show signatures graphically irrespective of their cryptographic validation status #13058

Closed

marco-c mentioned this pull request Apr 22, 2021

Digital signatures in pdf.js #1076

Closed

stephanrauh mentioned this pull request Apr 22, 2021

Remove the implementation of signatures in favor of the new implementation of pdf.js stephanrauh/ngx-extended-pdf-viewer#725

Closed

wojtekmaj mentioned this pull request Apr 23, 2021

Unimplemented widget field type "Sig", falling back to base field type. Introduced through a CDN wojtekmaj/react-pdf#772

Closed

4 tasks

Snuffleupagus mentioned this pull request May 24, 2021

eSignatures are not visible in the PDF.js #13428

Closed

kkoskelin mentioned this pull request May 24, 2021

BUG: Signature not displaying in Firefox ustaxcourt/ef-cms#7687

Closed

11 tasks

Cantfirmed mentioned this pull request Jun 13, 2021

Document Viewer: Upgrade PDF.js 2.9.35 primefaces-extensions/primefaces-extensions#122

Closed

Jefiozie mentioned this pull request Jul 27, 2021

Support new "Sig" type in pdfjs wojtekmaj/react-pdf#817

Closed

2 tasks

LAlves91 mentioned this pull request Aug 16, 2021

PDF open but signature not displaying. intbot/ng2-pdfjs-viewer#112

Closed

pixiwyn mentioned this pull request Oct 16, 2025

BUG: Signature not displaying in Firefox flexion/ef-cms#388

Closed

11 tasks

Uh oh!

Conversation

calixteman commented Apr 10, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Snuffleupagus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Snuffleupagus left a comment

Choose a reason for hiding this comment

Uh oh!

calixteman commented Apr 10, 2021

Uh oh!

pdfjsbot commented Apr 10, 2021

From: Bot.io (Windows)

Received

Uh oh!

pdfjsbot commented Apr 10, 2021

From: Bot.io (Linux m4)

Received

Uh oh!

Uh oh!

pdfjsbot commented Apr 10, 2021

From: Bot.io (Linux m4)

Failed

Uh oh!

pdfjsbot commented Apr 10, 2021

From: Bot.io (Windows)

Failed

Uh oh!

timvandermeij commented Apr 10, 2021

Uh oh!

timvandermeij commented Apr 10, 2021

Uh oh!

pdfjsbot commented Apr 10, 2021

From: Bot.io (Linux m4)

Received

Uh oh!

pdfjsbot commented Apr 10, 2021

From: Bot.io (Linux m4)

Success

Published

Uh oh!

timvandermeij commented Apr 10, 2021

Uh oh!

pdfjsbot commented Apr 10, 2021

From: Bot.io (Linux m4)

Received

Uh oh!

pdfjsbot commented Apr 10, 2021

From: Bot.io (Windows)

Received

Uh oh!

Uh oh!

pdfjsbot commented Apr 10, 2021

From: Bot.io (Linux m4)

Success

Uh oh!

pdfjsbot commented Apr 10, 2021

From: Bot.io (Windows)

Success

Uh oh!

CetinSert commented Apr 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Snuffleupagus commented Apr 11, 2021

Uh oh!

stephanrauh commented Apr 22, 2021

Uh oh!

Snuffleupagus commented Apr 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

CetinSert commented Apr 11, 2021 •

edited

Loading