[netcore] Simplify Array.Length/LongLength implementation - #17287
Closed
filipnavara wants to merge 2 commits into
Closed
filipnavara wants to merge 2 commits into
filipnavara wants to merge 2 commits into
Conversation
EgorBo
reviewed
Oct 11, 2019
| return length; | ||
| } | ||
| } | ||
| public int Length => checked ((int)Unsafe.As<RawData>(this).Count); |
Member
There was a problem hiding this comment.
I guess you will need to remove the intrinsic then 🙂
Contributor
Author
There was a problem hiding this comment.
Oh right, may not be worth it afterall.
Contributor
Author
There was a problem hiding this comment.
The motivation for this was dotnet/coreclr#27123. I was testing the grounds to see if we can share more of the code with CoreCLR eventually. The only reason to port it to non-netcore is code parity and removing the native code altogether. It doesn't generate better or worse code in the end so I am not sure if it's worth it.
filipnavara
marked this pull request as ready for review
October 11, 2019 15:19
filipnavara
requested review from
SamMonoRT,
akoeplinger,
lambdageek,
lewurm,
marek-safar,
steveisok and
vargaz
as code owners
October 11, 2019 15:19
Member
|
I want to hear what @vargaz thinks, but I think it's worth moving this to managed in non-netcore Mono and cleaning up the unmanaged code. |
Member
|
Closing as we have already intrinsic for this code paths |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.