Add a global action to add a new file in the explorer - resolves #5547 - #5597
Conversation
|
Hi Sam Verschueren (@SamVerschueren), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Sam Verschueren (@SamVerschueren), Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
| let workbenchActionsRegistry = <IWorkbenchActionRegistry>Registry.as(ActionExtensions.WorkbenchActions); | ||
| workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(SaveFileAsAction, SaveFileAsAction.ID, SaveFileAsAction.LABEL, { primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KEY_S }), category, ['save', 'as']); | ||
| workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(GlobalNewFileAction, GlobalNewFileAction.ID, GlobalNewFileAction.LABEL, { primary: KeyMod.CtrlCmd | KeyCode.KEY_N }), category, ['new', 'file']); | ||
| workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(GlobalNewUntitledFileAction, GlobalNewUntitledFileAction.ID, GlobalNewUntitledFileAction.LABEL, { primary: KeyMod.CtrlCmd | KeyCode.KEY_N }), category, ['new', 'file']); |
There was a problem hiding this comment.
Maybe add the "untitled" to the keywords?
There was a problem hiding this comment.
👍
|
Sam Verschueren (@SamVerschueren) cool, added some comments! |
|
Thanks for the feedback, I adjusted accordingly. The only concern is the translation of |
|
👍 |
|
Awesome, thanks Benjamin Pasero (@bpasero) for helping me out and merging my PR :). |
|
Sam Verschueren (@SamVerschueren) expecting a PR from every issue you file from now on :) |
|
Hehe, I'll do my best :). The project is quite complex to be honest :p. |
|
Welcome to our life ;) |
Adds the possibility of binding a keyboard shortcut to a
Create new fileaction. Resolves #5547Benjamin Pasero (@bpasero) I believe this should do the trick :)