chore: revert to electron@13 - #143851
Merged
Merged
Conversation
deepak1556
force-pushed
the
robo/revert_electron_16
branch
from
February 24, 2022 05:13
fd5ff02 to
3de7cd2
Compare
bpasero
suggested changes
Feb 24, 2022
bpasero
left a comment
Contributor
There was a problem hiding this comment.
As discussed I would suggest to do a full revert of the commits that went in first and then do selected changes on top that we want to keep. That would ensure we are not shipping a partial untested change.
I would suggest a PR composed of these commits:
- revert of the big E16 change
- revert of E16 associated changes (such as keytar update)
- 1 commit that selectively restores changes as needed
That would also make it much easier to review.
deepak1556
force-pushed
the
robo/revert_electron_16
branch
from
February 24, 2022 14:16
0f6beaf to
bc6cd21
Compare
bpasero
self-requested a review
February 24, 2022 16:47
bpasero
approved these changes
Feb 24, 2022
deepak1556
added a commit
that referenced
this pull request
Feb 25, 2022
This reverts commit df645f1.
deepak1556
added a commit
that referenced
this pull request
Feb 28, 2022
This reverts commit df645f1.
deepak1556
added a commit
that referenced
this pull request
Mar 2, 2022
This reverts commit df645f1.
deepak1556
added a commit
that referenced
this pull request
Mar 5, 2022
This reverts commit df645f1.
deepak1556
added a commit
that referenced
this pull request
Mar 7, 2022
This reverts commit df645f1.
deepak1556
added a commit
that referenced
this pull request
Mar 9, 2022
This reverts commit df645f1.
deepak1556
added a commit
that referenced
this pull request
Mar 9, 2022
This reverts commit df645f1.
deepak1556
added a commit
that referenced
this pull request
Mar 10, 2022
This reverts commit df645f1.
deepak1556
added a commit
that referenced
this pull request
Mar 10, 2022
* chore: bump [email protected] * Revert "chore: revert to electron@13 (#143851)" This reverts commit df645f1. * chore: bump [email protected] * Revert "ci: fix build with latest node-gyp" This reverts commit c3e948a. * chore: revert ci changes for node v16 * chore: update yarn.lock * chore: bump [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electron 16 update will be adopted in March 2022 milestone due to release blockers
PR contains following changes:
Will reopen the following issues once this PR gets merged,
#120431
#133820
#131714
#93615
#136787
#50386
#138721
#84453
fixed-in-electron-16 query