chore: update to electron 16 - #137241
Conversation
bf2fe22 to
f704913
Compare
926e529 to
ae4ddcd
Compare
|
I'm getting an issue where clicking on another file in the file explorer results in several terminals
|
|
The issue does not reproduce as much with extensions (including Git, GitHub, and GitHub Authentication) disabled, but even with the extensions disabled, when I launch OSS, I get a command prompt telling me that types from types-registry are being installed, as well as another command prompt from ripgrep. |
rzhao271
left a comment
There was a problem hiding this comment.
I was interested in seeing what changed. Left some comments
| options.cwd = cwd; | ||
| } | ||
| const killProcess = cp.execFile('taskkill', ['/T', '/F', '/PID', process.pid.toString()], options); | ||
| const killProcess = cp.execFile('taskkill', ['/T', '/F', '/PID', process.pid!.toString()], options); |
There was a problem hiding this comment.
I get a 500 error when trying to view the nodejs docs. Did the potential return values of process.pid change recently? In the worst case, we would need to add more fallback logic if it really is the case that sometimes, process.pid isn't valid anymore.
There was a problem hiding this comment.
There is no behavior change in this version, documentation was updated to reflect the correct behavior and types were updated accordingly nodejs/node@a3c564bead
pid will be undefined only when the child process fails to launch and the process is not connected to a shell. Feel free to update this utility for the case when pid is undefined and that change can target main branch today instead of changing in this PR.
This reverts commit 7b48fa3.
* Revert "chore: update to electron 16 (#137241)" This reverts commit 01df559. This reverts commit 4630133 * ci: fix remote compiler for sdl-scan * chore: fix remote/.yarnrc * chore: fix build/npm/postinstall.js * chore: rm crash reporter from shared process * chore: rm crash reporter from ext host * chore: fix build/lib/layersChecker.ts * :chore: preserve some more changes * fix tests Co-authored-by: Benjamin Pasero <[email protected]>
Todo:
Fixes #120431
Fixes #133820
Fixes #131714
Fixes #93615
Fixes #136787
Fixes #50386 , Depends on #126113
Fixes #138721
Fixes #84453