Skip to content

perf: avoid duplicate symbol link lookup in GetNameTypeOfSymbol - #64305

Merged
Jake Bailey (jakebailey) merged 1 commit into
microsoft:mainfrom
camc314:codex/single-lookup-name-type
Sep 17, 2026
Merged

Jake Bailey (jakebailey) merged 1 commit into
microsoft:mainfrom
camc314:codex/single-lookup-name-type

Conversation

@camc314

Copy link
Copy Markdown
Contributor

func (s *symbolArenaLinkStore[V]) Has(symbol *ast.Symbol) bool {
return s.TryGet(symbol) != nil
}

calling Has already calls TryGet. so this code was calling TryGet twice wchich is unnecessary.

Copilot AI balanced review requested due to automatic review settings September 17, 2026 06:23
@typescript-automation typescript-automation Bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 17, 2026
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Sep 17, 2026
@typescript-automation

Copy link
Copy Markdown

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@camc314 Cameron (camc314) changed the title perf: avoid duplicate symbol link lookup in GetNameTypeOfSymbol perf: avoid duplicate symbol link lookup in GetNameTypeOfSymbol Sep 17, 2026
@jakebailey
Jake Bailey (jakebailey) added this pull request to the merge queue Sep 17, 2026
Merged via the queue into microsoft:main with commit 8973583 Sep 17, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants