Add support for importing JSON modules "as const" - #64301
Open
James Prevett (james-pre) wants to merge 2 commits into
Open
James Prevett (james-pre) wants to merge 2 commits into
James Prevett (james-pre) wants to merge 2 commits into
Conversation
Accept test baselines
|
The TypeScript team hasn't accepted the linked issue #32063. If you can get it accepted, this PR will have a better chance of being reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements importing JSON modules with const context, which has the same effect as an
as constassertion.This was discussed in #32063. The issue suggests using a
constimport attribute, however this PR uses a compiler option which is much simpler and should be more maintainable.This feature is opt-in, so no existing code will be broken. It can be enabled by setting
compilerOptions.importJsonAsConsttotruein tsconfig.Fixes #32063. Note this is the same work from microsoft/typescript-go#2539 and #63008.