Skip to content

Update release-7.0 for TS7 tagged releases - #64287

Open
Jake Bailey (jakebailey) wants to merge 8 commits into
microsoft:release-7.0from
jakebailey:prototype-release-7.0
Open

Jake Bailey (jakebailey) wants to merge 8 commits into
microsoft:release-7.0from
jakebailey:prototype-release-7.0

Conversation

@jakebailey

Copy link
Copy Markdown
Member

Pull in some required changes for the release branch to function.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The release CI changes require final human review.

Pull request overview

Updates release-branch Azure Pipelines for the 7.0 release flow, including prerelease packaging, renamed build resources, npm registry configuration, and pinned VSCE setup.

Changes:

  • Renames release build pipeline references.
  • Adds build-number prerelease identifiers.
  • Centralizes pinned VSCE setup and updates npm registry configuration.
File summaries
File Description
tools/pipelines/typescript-publish.yml Uses release build artifacts and shared VSCE setup.
tools/pipelines/typescript-build.yml Adds prerelease versioning to release tasks.
tools/pipelines/steps/setup-vsce.yml Installs the pinned VSCE version.
tools/pipelines/steps/setup-node-npm-ci.yml Updates npm registry configuration.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite (auto)

Note

Copilot is running an experiment and ran this review at Lite.


💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@jakebailey Jake Bailey (jakebailey) changed the title Cherry-pick CI updates to release-7.0 Update release-7.0 for TS7 tagged releases Sep 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The package smoke test must compare the normalized compiler version exactly rather than using a substring check.

Review details

Suppressed comments (1)

Herebyfile.mjs:1972

  • This substring check can pass for the wrong compiler version (for example, expected 7.0.3 also matches output containing 17.0.3), so a broken package can pass the smoke test. Compare the normalized --version output with the expected Version ${getVersion()} value instead.
        assert(versionOutput.includes(getVersion()), `Expected version output to contain ${getVersion()}, got ${versionOutput.trim()}`);
  • Files reviewed: 5/5 changed files
  • Comments generated: 0 new
  • Review effort level: Lite (auto)

Note

Copilot is running an experiment and ran this review at Lite.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Production signing and publishing behavior depends on external Azure pipeline resources that cannot be validated locally.

Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-project-automation github-project-automation Bot moved this from Not started to Needs merge in PR Backlog Sep 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The package validation test currently fails because it omits the required ES5 target.

Get a fresh assessment by requesting another Copilot review.

Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 1
  • Review effort level: Lite (auto)

Note

Copilot is running an experiment and ran this review at Lite.

Comment thread Herebyfile.mjs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Needs merge

Development

Successfully merging this pull request may close these issues.

3 participants