test: cover contextual parameter type caching - #64281
Open
Chenxu Lu (luchenxu73) wants to merge 1 commit into
Open
Chenxu Lu (luchenxu73) wants to merge 1 commit into
Chenxu Lu (luchenxu73) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test and baselines correctly cover the reported premature-caching regression.
Pull request overview
Adds regression coverage for contextual parameter type caching and widening, addressing #64278.
Changes:
- Adds the contextual default-parameter scenario.
- Records expected type and symbol baselines.
File summaries
| File | Description |
|---|---|
tsc/testdata/tests/cases/compiler/contextuallyTypedParametersWithInitializers2.ts |
Adds the regression case. |
tsc/testdata/baselines/reference/compiler/contextuallyTypedParametersWithInitializers2.types |
Captures inferred types. |
tsc/testdata/baselines/reference/compiler/contextuallyTypedParametersWithInitializers2.symbols |
Captures symbol resolution. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64278
Just to add new tests to cover the contextual type