fix(a11y): use --ms-yellow-fg for remaining amber text/icons - #91
Open
evanclan wants to merge 1 commit into
Open
fix(a11y): use --ms-yellow-fg for remaining amber text/icons#91evanclan wants to merge 1 commit into
evanclan wants to merge 1 commit into
Conversation
microsoft#78 introduced theme-aware --ms-yellow-fg for WCAG 2.1 AA amber foreground, but four inline component styles still used bright --ms-yellow / #FFB900 and fail (~1.7:1) on light/crimson themes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finishes the amber-foreground contrast sweep started in #78 (and the broader WCAG pass in #75/#77). Four React components still painted amber text/icons with bright
--ms-yellow/ hardcoded#FFB900, which fails WCAG 2.1 AA (~1.7:1) on light and crimson themes. Repoint them to theme-aware--ms-yellow-fg.Problem
#78 added
--ms-yellow-fg(bright on dark/aurora, dark gold#8A6A00on light/crimson) and updated the CSS usages, but these inline styles were missed:QuestPanel.tsxHelpModal.tsxWelcomeModal.tsx#FFB900)DataSourcesModal.tsxOn light/crimson, those surfaces still show the brand fill yellow as foreground text.
Solution
Replace the four inline colors with
var(--ms-yellow-fg). Brand fill--ms-yellow(paired with black text on badges) and decorative borders are left untouched — matching the #78 contract documented indocs/theme-authoring-guide.md.Out of scope
OntologyGraph.tsx(entity/relationship accent strokes, not UI text)#FFB900in ontology data)Test plan
npm run test:a11y— 84/84 passed (includes amber-fg ≥4.5:1 on every theme surface)Related
--ms-yellow-fgand fixed CSS usagesMade with Cursor